use naked_asm! in #[naked] functions
#686
Merged
+15
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rust-lang/rust#130146 only recently merged so this just needs to wait for the nightly (few hours after 00:00 UTC) |
folkertdev
force-pushed
the
use-naked-asm
branch
from
ee5d32a
to
a863636
Compare
|
all good now |
This was referenced Sep 20, 2024
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 24, 2024
This includes the following: - rust-lang/compiler-builtins#686 - rust-lang/compiler-builtins#622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of an effort to stabilize
#[naked]functions rust-lang/rust#90957This PR uses
naked_asm!instead ofasm!in all#[naked]functions, and removesoptions(noreturn)which is implicit withnaked_asm!the PR introducing
naked_asm!just got merged rust-lang/rust#130146, so it'll likely take some time before this can get merged. Doescompiler-builtinsuse the latest nightly, or is it a little behind?cc @Amanieu